Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacktrace to new errors #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add stacktrace to new errors #5

wants to merge 1 commit into from

Conversation

vearutop
Copy link
Member

No description provided.

@github-actions
Copy link

Unit Test Coverage

total: (statements) 80.3%

Coverage diff with base branch
5c5
< github.com/bool64/ctxd/error.go	LogError	100.0%
---
> github.com/bool64/ctxd/error.go	LogError	85.7%
45c45,56
< total:	(statements)	96.6%
---
> github.com/bool64/ctxd/stack.go	pc	100.0%
> github.com/bool64/ctxd/stack.go	file	80.0%
> github.com/bool64/ctxd/stack.go	line	80.0%
> github.com/bool64/ctxd/stack.go	name	0.0%
> github.com/bool64/ctxd/stack.go	Format	63.6%
> github.com/bool64/ctxd/stack.go	MarshalText	0.0%
> github.com/bool64/ctxd/stack.go	Format	0.0%
> github.com/bool64/ctxd/stack.go	formatSlice	0.0%
> github.com/bool64/ctxd/stack.go	StackTrace	100.0%
> github.com/bool64/ctxd/stack.go	callers	100.0%
> github.com/bool64/ctxd/stack.go	funcname	0.0%
> total:	(statements)	80.3%

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@abb0344). Click here to learn what that means.
The diff coverage is 45.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage          ?   77.37%           
=========================================
  Files             ?        7           
  Lines             ?      221           
  Branches          ?        0           
=========================================
  Hits              ?      171           
  Misses            ?       43           
  Partials          ?        7           
Flag Coverage Δ
unittests 77.37% <45.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stack.go 40.00% <40.00%> (ø)
error.go 98.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb0344...2e7e548. Read the comment docs.

@github-actions
Copy link

Benchmark Result

Benchmark diff with base branch
name                     old time/op    new time/op    delta
SetFields-2                 573ns ± 6%     557ns ± 4%      ~     (p=0.151 n=5+5)
StructuredError_Error-2     881ns ± 4%    1966ns ± 5%  +123.08%  (p=0.008 n=5+5)
Fmt_Errorf-2                541ns ± 7%     494ns ± 3%    -8.69%  (p=0.008 n=5+5)
WrapError-2                1.10µs ± 4%    2.26µs ± 1%  +104.91%  (p=0.008 n=5+5)

name                     old alloc/op   new alloc/op   delta
SetFields-2                  224B ± 0%      224B ± 0%      ~     (all equal)
StructuredError_Error-2      224B ± 0%      504B ± 0%  +125.00%  (p=0.008 n=5+5)
Fmt_Errorf-2                96.0B ± 0%     96.0B ± 0%      ~     (all equal)
WrapError-2                  256B ± 0%      536B ± 0%  +109.38%  (p=0.008 n=5+5)

name                     old allocs/op  new allocs/op  delta
SetFields-2                  5.00 ± 0%      5.00 ± 0%      ~     (all equal)
StructuredError_Error-2      6.00 ± 0%      8.00 ± 0%   +33.33%  (p=0.008 n=5+5)
Fmt_Errorf-2                 2.00 ± 0%      2.00 ± 0%      ~     (all equal)
WrapError-2                  5.00 ± 0%      7.00 ± 0%   +40.00%  (p=0.008 n=5+5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants