Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry, skip-error, keywords options #23

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Conversation

passos
Copy link

@passos passos commented Dec 2, 2023

add retry times option to retry when book download failed
add skip-error option to continue downloading the next book if the current book download failed
add keywords option to only download the book that match the keywords

@passos passos marked this pull request as draft December 2, 2023 11:21
@passos passos marked this pull request as ready for review December 2, 2023 11:21
@passos passos force-pushed the options branch 4 times, most recently from 15dacee to 2f93a98 Compare December 2, 2023 12:16
@syhily
Copy link
Member

syhily commented Dec 27, 2023

Thanks for your contribution. I will review this PR ASAP.

cmd/flags/config.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
internal/fetcher/fetcher.go Outdated Show resolved Hide resolved
internal/fetcher/fetcher.go Outdated Show resolved Hide resolved
@syhily
Copy link
Member

syhily commented Dec 28, 2023

I plan to add the code tweak on your works. This PR is gona be merged soon.

@syhily syhily merged commit ce64f50 into bookstairs:master Dec 28, 2023
1 check passed
@syhily
Copy link
Member

syhily commented Dec 28, 2023

@passos Thanks for your contribution. This PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants