close #236 fix rubocop linter #237
Open
+340
−318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theachoem
force-pushed
the
236-fix-rubocop-linter
branch
2 times, most recently
from
866fd0c to
4bd9170
Compare
theachoem
force-pushed
the
236-fix-rubocop-linter
branch
from
4bd9170 to
3e6f86c
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
theachoem
force-pushed
the
236-fix-rubocop-linter
branch
from
3e6f86c to
597f4a0
Compare
theachoem
force-pushed
the
236-fix-rubocop-linter
branch
from
597f4a0 to
3c49421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is hard to modify any file with ruby LSP enabled, it blue warning all over the place. Anyway, Ruby LSP & rubocop does make our code better, so I carefully enabled and fix them file by file.