close #238 follow order state machine for payway_v2 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theachoem
force-pushed
the
238-follow-order-state-machine
branch
from
0f08882 to
43f4b82
Compare
theachoem
force-pushed
the
236-fix-rubocop-linter
branch
from
4bd9170 to
3e6f86c
Compare
theachoem
force-pushed
the
238-follow-order-state-machine
branch
from
43f4b82 to
2b3f867
Compare
theachoem
force-pushed
the
236-fix-rubocop-linter
branch
from
3e6f86c to
597f4a0
Compare
theachoem
force-pushed
the
238-follow-order-state-machine
branch
8 times, most recently
from
3e347cd to
30df585
Compare
theachoem
changed the title
theachoem
force-pushed
the
238-follow-order-state-machine
branch
5 times, most recently
from
be24ac1 to
575bd4a
Compare
theachoem
force-pushed
the
236-fix-rubocop-linter
branch
from
597f4a0 to
3c49421
Compare
theachoem
force-pushed
the
238-follow-order-state-machine
branch
3 times, most recently
from
0e6eb98 to
1ef147f
Compare
theachoem
force-pushed
the
238-follow-order-state-machine
branch
5 times, most recently
from
24f1005 to
5a3c639
Compare
theachoem
force-pushed
the
238-follow-order-state-machine
branch
13 times, most recently
from
c05bb44 to
10e8efb
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15789919 | Triggered | Generic High Entropy Secret | 4501d6f | spec/services/vpago/payment_url_constructor_spec.rb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
theachoem
force-pushed
the
238-follow-order-state-machine
branch
from
10e8efb to
e3dac49
Compare
theachoem
force-pushed
the
238-follow-order-state-machine
branch
2 times, most recently
from
373e736 to
fd475fb
Compare
theachoem
force-pushed
the
238-follow-order-state-machine
branch
2 times, most recently
from
bcc2d98 to
a265735
Compare
With 4 api routes for all payment methods. This will help integrating spree_vpago much easier. - GET: /vpago_payments/checkout (HTML) - GET: /vpago_payments/processing (HTML) - GET: /vpago_payments/success (HTML) - POST: /vpago_payments/process_payment (JSON) - (This is API to process the payment, can call from ABA or our app)
theachoem
force-pushed
the
238-follow-order-state-machine
branch
from
a265735 to
4501d6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Processing Flow
After paid, ABA push back to BookMe+, then it will process payment & order in queue with following steps:
Demo
Screen.Recording.2025-02-05.at.11.20.53.in.the.morning.mp4