Add support for deep oneOf inheritance #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands discriminator inheritance resolution to support deep inheritance hierarchies. It also resolves several complicated assumptions found in NJsonSchema that would limit future support for complex inheritance schemes.
The core of the approach is to resolve
oneOf
inheritance in two passes:a. if schema is inline, move the discriminator to a separate type definition
b. if the discriminator has
oneOf
declarations, inject the discriminator asallOf
schema in each of the derived schemasA simple regression test for a deep inheritance schema is added, but more extensive tests will be required in the future to ensure all edge cases are covered.