Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use a new action to better check the contribution content #149

Merged
merged 15 commits into from
Nov 24, 2023

Conversation

benjaminParisel
Copy link
Contributor

@benjaminParisel benjaminParisel commented Oct 19, 2023

Use new action to validate if contribution (PR) follows the guidelines on documentation content

For now only check if:

  • files contain:description: attributes
  • files not contain any forbidden attribute

Covers bonitasoft/bonita-documentation-site#591
Covers bonitasoft/bonita-documentation-site#422

Use new action to validate if contribution (PR) follows the guidelines on documentation content

For now only check if:
files contain:description: attributes
files not contain any forbidden attribute

Covers bonitasoft/bonita-documentation-site#591
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I made renaming suggestions.

.github/workflows/contribution-check.yml Outdated Show resolved Hide resolved
.github/workflows/contribution-check.yml Outdated Show resolved Hide resolved
@tbouffard tbouffard marked this pull request as draft October 20, 2023 13:58
@tbouffard
Copy link
Member

ℹ️ Put in draft, we are going to use a centralized actions/workflows to manage the configuration in a single place

Copy link

github-actions bot commented Nov 17, 2023

🎊 PR Preview bc10d31 has been successfully built and deployed to https://bonitasoft-bonita-labs-doc-build_preview-pr-149.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

Copy link

📝 Check the pages that have been modified

In order to merge this pull request, you need to check your updates with the following url.

🔍 Updated pages

The following pages were updated, please ensure that the display is correct:

@benjaminParisel benjaminParisel marked this pull request as ready for review November 24, 2023 14:38
@benjaminParisel benjaminParisel merged commit c7430b0 into master Nov 24, 2023
2 checks passed
@benjaminParisel benjaminParisel deleted the chore/use_contribution_actions branch November 24, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants