ci(surge-deploy): try to limit API rate limit errors #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have rate limit errors when deploying doc PR with surge. Try using the BONITA_CI_PAT to avoid rate limit error
tbouffard
changed the title
tbouffard
reviewed
Jul 2, 2024
| @@ -24,6 +24,7 @@ jobs: | |||
| id: surge-preview-tools | |||
| with: | |||
| surge-token: ${{ secrets.SURGE_TOKEN_DOC }} | |||
| github-token: ${{ secrets.BONITA_CI_PAT }} # Avoid rate limiting produced with default GITHUB_TOKEN | |||
There was a problem hiding this comment.
thought: The afc163/surge-preview action also do some GH API calls (it does the exact same call as the surge-preview-tools action)
So, it should probably use the PAT.
Notice that this will change the author of PR comment created/updated by the action from github-actions bot to bonita-ci bot. This has no impact for contributors.
There was a problem hiding this comment.
It seems better with PAT after some tests on bonita-doc pr
The logic is duplicated from the reusable workflow and so, it must be updated as well
|
tbouffard
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have rate limit errors when deploying doc PR with surge.
Try using the
BONITA_CI_PATinstead ofGITHUB_TOKENto avoid rate limit error