Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use a new action to better check the contribution content #216

Closed
wants to merge 1 commit into from

Conversation

benjaminParisel
Copy link
Contributor

@benjaminParisel benjaminParisel commented Oct 19, 2023

Use new action to validate if contribution (PR) follows the guidelines on documentation content

For now only check if:

  • files contain:description: attributes
  • files not contain any forbidden attribute

Covers bonitasoft/bonita-documentation-site#591
Covers bonitasoft/bonita-documentation-site#422

Use new action to validate if contribution (PR) follows the guidelines on documentation content

For now only check if:
files contain:description: attributes
files not contain any forbidden attribute

Covers bonitasoft/bonita-documentation-site#591
@tbouffard
Copy link
Member

ℹ️ Put in draft, we are going to use a centralized actions/workflows to manage the configuration in a single place

@tbouffard tbouffard marked this pull request as draft October 20, 2023 13:53
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ we should target the 3.6 branch (currently it is the 4.0 branch) because it relates to the oldest supported version

@rbioteau rbioteau changed the base branch from 4.0 to 3.6 November 14, 2023 15:22
@rbioteau rbioteau changed the base branch from 3.6 to 4.0 November 14, 2023 15:22
@@ -9,8 +9,8 @@ jobs:
runs-on: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ missing permissions pull-requests: write
See bonitasoft/bonita-doc@ed39722

@benjaminParisel
Copy link
Contributor Author

Covers by another PR ! #218

@tbouffard tbouffard deleted the chore/use_new_contribution_actions branch November 24, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants