Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecation and/or removal of the pr-diff-checker action #119

Closed
tbouffard opened this issue Oct 16, 2023 · 1 comment · Fixed by #127
Closed

Consider deprecation and/or removal of the pr-diff-checker action #119

tbouffard opened this issue Oct 16, 2023 · 1 comment · Fixed by #127
Assignees
Labels
enhancement New feature or request

Comments

@tbouffard
Copy link
Member

tbouffard commented Oct 16, 2023

We are introducing a new pr-antora-content-guidelines-checker action which is more powerful and easier to improve. See #115.

With @benjaminParisel, we are planning to make the new action available and start using it in the https://github.com/bonitasoft/bonita-doc repository to ensure it covers all the current needs and work as expected.
When we will consider it as mature enough, we will apply it to all documentation content repositories. At that time, we will be able to remove the former action.

Implementation notes

This will be a breaking change requiring a new major version. We could do it as the same time as we implement #116

Usage of the pr-diff-checker action in bonitasoft repositories

Document content repositories no longer use the pr-diff-checker action. See https://github.com/search?q=org%3Abonitasoft%20pr-diff-checker&type=code
They are now using a shared workflow which relies on the new pr-files-checker action. See https://github.com/bonitasoft/bonita-labs-doc/pull/149/files

This is part of

@tbouffard
Copy link
Member Author

The action is going to be removed. All documentation content repositories are using the new action for a while.

benjaminParisel pushed a commit that referenced this issue Apr 15, 2024
This action was deprecated. `pr-antora-content-guidelines-checker` must
be used instead.

Closes #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant