Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All JavaScript actions: consider requiring Node 20 to run #116

Closed
tbouffard opened this issue Sep 4, 2023 · 0 comments · Fixed by #128
Closed

All JavaScript actions: consider requiring Node 20 to run #116

tbouffard opened this issue Sep 4, 2023 · 0 comments · Fixed by #128
Labels
chore Something about the build

Comments

@tbouffard
Copy link
Member

tbouffard commented Sep 4, 2023 •
edited
Loading

From https://github.com/actions/checkout/pull/1436/files

Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0.
Node16 has en end of life on 11 Sep 2023.
This PR updates the default runtime to node20, rather then node16

We may request node 18 or 20 (check node 20 availability for all os provided by GH hosted runners).
Also consider updating the node version required to build the JS actions, see #118.

IMPORTANT: as this is a breaking change, a major version of the actions must be released.
We could implement it as the same time as we implement #119.
@tbouffard tbouffard added the chore Something about the build label Sep 4, 2023
@tbouffard tbouffard changed the title All JavaScript actions: consider requiring a newer version of Node All JavaScript actions: consider requiring Node 20 to run Sep 25, 2023
This was referenced Sep 27, 2023
Closed
Open
This was referenced Oct 16, 2023
Closed
Closed
@tbouffard tbouffard mentioned this issue Feb 5, 2024
Closed
@tbouffard tbouffard mentioned this issue Apr 5, 2024
Merged
@tbouffard tbouffard mentioned this issue Apr 15, 2024
Merged
benjaminParisel pushed a commit that referenced this issue Apr 15, 2024
@tbouffard
chore: build pr-antora-content-guidelines-checker with node 20 (#128)
a4704d2 
It was previously built with node 16 which is EOL.
Add a GH workflow to validate that the build the action is working.

closes #116 (already done with other PR)
closes #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Something about the build
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: build pr-antora-content-guidelines-checker with node 20 bonitasoft/actions
1 participant
@tbouffard