Don't enable smtputf8 when running on alpine on container restart #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postfix_disable_utf8
checks if its running on alpine and if so, disables smtputf8.However, the check is wrong. Consider this scenario:
no
using-e POSTFIX_smtputf8_enable=no
elif
branch is taken and smtputf8 is actually enabled on alpine.no
again, so no harm done.We actually encountered this on our system:
This PR adds an additional check for non-existence of
/etfc/alpine-release
to theelif
branch to make sure that branch is only taken in non-alpine containers.