Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
While working on a project where I needed to provide our hours in UTC times, I noticed a bug with 11pm closing times where an hour would be "eaten" by
business_hours.after(time)
if time was right up against the end of the work day/11pm:Strangely, the reverse problem didn't exist.
4.business_hours.before(<Tues@4pm>)
accurately returned Mon@9pm.What?
calculate_after
:Time.roll_forward(after_time)
when after_time is 00:00:00, use the logic for checking ifafter_time
is outside of work hours instead so that thedelta
isn't lost.calculate_before
for simplicity.