Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling for non-root path URLs #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philippjfr
Copy link
Collaborator

Fixes #21

@MarcSkovMadsen
Copy link

MarcSkovMadsen commented Sep 23, 2024

It works for me on my Jupyterhub. Thx ❤️.

@MarcSkovMadsen
Copy link

MarcSkovMadsen commented Sep 23, 2024

One note is that on my Jupyterhub I need to add fastapi dev main.py --root-path /NAMESPACE/user/USERNAME/vscode/proxy/8000/ to get the /docs endpoint working. The Panel apps seems unaffected by this and continue to work.

@MarcSkovMadsen
Copy link

When this is deployed I will try also deploy fastapi Panel apps behind a reverse proxy on our kubernetes cluster. Will be awesome.

@philippjfr
Copy link
Collaborator Author

One note is that on my Jupyterhub I need to add fastapi dev main.py --root-path /NAMESPACE/user/USERNAME/vscode/proxy/8000/ to get the /docs endpoint working. The Panel apps seems unaffected by this and continue to work.

Right, maybe we can note that in our docs as well. This is required on the FastAPI side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not work with prefix
2 participants