Allow MaxAge 0 to mean session-based cookie and not delete. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't work as intended, as setting a MaxAge of 0 means that the backing Redis store will try to call Line 327 in 05d7b3b The challenge is that a "session cookie" with a server-side store requires you to make an assumption about how long your backing store should hold onto the cookie. If you set the MaxAge on the client-side cookie as 0, you're likely to want some short-lived-but-not-too-short-because-they-might-leave-their-tab-open TTL on the server side. |
elithrar
suggested changes
Nov 27, 2018
AnikHasibul
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.