Skip to content

Commit

Permalink
Avoid logging in __del__ functions (#76)
Browse files Browse the repository at this point in the history
  • Loading branch information
ehsantn authored Dec 19, 2024
1 parent 9c34d32 commit 827e909
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 20 deletions.
8 changes: 0 additions & 8 deletions bodo/pandas/array_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,6 @@ def __del__(self):
otherwise we do nothing because the data is already collected/deleted.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazyArrayManager] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down Expand Up @@ -501,10 +497,6 @@ def __del__(self):
otherwise we do nothing because the data is already collected/deleted.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazySingleArrayManager] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down
4 changes: 0 additions & 4 deletions bodo/pandas/arrow/array.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,6 @@ def __del__(self):
Delete the result from workers if it exists.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazyArrowExtensionArray] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down
8 changes: 0 additions & 8 deletions bodo/pandas/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,6 @@ def __del__(self):
Delete the result from the workers if it hasn't been collected yet.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazyBlockManager] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down Expand Up @@ -437,10 +433,6 @@ def __del__(self):
Delete the result from the workers if it hasn't been collected yet.
"""
if (r_id := self._md_result_id) is not None:
debug_msg(
self.logger,
f"[LazySingleBlockManager] Asking workers to delete result '{r_id}'",
)
assert self._del_func is not None
self._del_func(r_id)
self._del_func = None
Expand Down

0 comments on commit 827e909

Please sign in to comment.