[xml] More test cases.

bobrnor · Mar 21, 2017 · 6017651 · 6017651
1 parent c5eac84
commit 6017651
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/common_data_for_test.go b/common_data_for_test.go
@@ -498,6 +498,16 @@ var tests = []TestData{
 			BinaryFormat:   []byte{98, 112, 108, 105, 115, 116, 48, 48, 35, 127, 240, 0, 0, 0, 0, 0, 0, 8, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 17},
 		},
 	},
+	{
+		Name: "Floating-Point Negative Infinity",
+		Data: math.Inf(-1),
+		Expected: map[int][]byte{
+			OpenStepFormat: []byte(`-Inf`),
+			GNUStepFormat:  []byte(`<*R-Inf>`),
+			XMLFormat:      []byte(xmlPreamble + `<plist version="1.0"><real>-inf</real></plist>`),
+			BinaryFormat:   []byte{98, 112, 108, 105, 115, 116, 48, 48, 35, 255, 240, 0, 0, 0, 0, 0, 0, 8, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 17},
+		},
+	},
 	{
 		Name: "UTF-8 string",
 		Data: []string{"Hello, ASCII", "Hello, 世界"},

diff --git a/xml_test.go b/xml_test.go
@@ -45,16 +45,17 @@ func TestVariousIllegalXMLPlists(t *testing.T) {
 		"<plist><data>",
 		"<plist><date>",
 		"<plist><array>",
+		"<plist/>",
 		"<pl",
 		"bplist00",
 	}
 
 	for _, plist := range plists {
 		buf := bytes.NewReader([]byte(plist))
 		d := newXMLPlistParser(buf)
-		_, err := d.parseDocument()
+		obj, err := d.parseDocument()
 		t.Logf("Error: %v", err)
-		if err == nil {
+		if obj != nil && err == nil {
 			t.Error("Expected error, received nothing.")
 		}
 	}