Added OAuth authentication, Project.searchAssignableUsers #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with two implementations (necessary to support OAuth), added Project.searchAssignableUsers
|
|
||
| private HttpClient httpClient = null; | ||
| private ICredentials creds = null; | ||
| private HttpContext context; |
There was a problem hiding this comment.
I don't see this being set anywhere by default. Can you initialise null?
There was a problem hiding this comment.
You mean context?
Fields in Java are set to null by default.
There was a problem hiding this comment.
Ah I didn't realise that. I always initialise out of habit from my C days.
|
Thanks for implementing OAuth support! Despite the large change, I think there's a lot of value in including it. Can you rebase against master? Also please add this to the pom: Also, I'd like @chaplinkyle to test attachments since he wrote that code. |
|
I'll have more changes in my local version I need to merge as well. |
hmdsd7316
reviewed
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major change and it's fine if you reject it.
It adds several dependencies to get JiraClient to support OAuth via fernandezpablo85/scribe-java (which required RestClient to become an abstract base class).