Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gateway strategy plus test cases #449

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: add gateway strategy plus test cases #449

wants to merge 6 commits into from

Conversation

nakul1010
Copy link
Contributor

@nakul1010 nakul1010 commented Jan 7, 2025 •
edited
Loading

📝 Description

  • Relocates strategy contracts to the BOB repository.
  • Performs end-to-end testing of strategies on the mainnet.
  • Adds unit tests for validation.

Additionally, partners and developers integrating new strategies should ensure valid end-to-end tests and unit tests are provided.

@nakul1010 nakul1010 self-assigned this Jan 7, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c669b67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 5:26am

@nakul1010 nakul1010 marked this pull request as draft January 7, 2025 04:32
@nakul1010 nakul1010 force-pushed the feat/add_gateway_interfaces_plus_tests branch from f2da468 to a278043 Compare January 10, 2025 06:43
@nakul1010 nakul1010 changed the title (WIP)feat: add gateway strategy plus test cases feat: add gateway strategy plus test cases Jan 13, 2025
@nakul1010 nakul1010 marked this pull request as ready for review January 13, 2025 05:32
@nakul1010 nakul1010 requested a review from gregdhill January 13, 2025 05:37
derrekcoleman
derrekcoleman reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@derrekcoleman derrekcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the folder structure, noted for docs and comms with integratooors

I look forward to seeing what people do with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrekcoleman derrekcoleman derrekcoleman left review comments

@gregdhill gregdhill Awaiting requested review from gregdhill

At least 1 approving review is required to merge this pull request.

Assignees

@nakul1010 nakul1010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nakul1010 @derrekcoleman