Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QOL improvements for debugging #318

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

QOL improvements for debugging #318

wants to merge 3 commits into from

Conversation

coyotte508
Copy link
Member

ok @zeitlinger couldn't reproduce the autocharge problem locally :(

Reverting the hotfix, maybe it was something residual?

@coyotte508 coyotte508 requested a review from zeitlinger June 20, 2022 20:47
@coyotte508 coyotte508 linked an issue Jun 20, 2022 that may be closed by this pull request
Look into autocharge #317
Open
@gitpod-io
Copy link

gitpod-io bot commented Jun 20, 2022

@zeitlinger
Copy link
Member

this PR doesn't revert the hotfix - but the hotfix shouldn't do anything bad anyways.

@coyotte508
Copy link
Member Author

coyotte508 commented Jun 21, 2022 •
edited
Loading

It does revert the fix: https://github.com/boardgamers/gaia-project/pull/318/files#diff-2948fb20dcc7f40db1743e083858159bceedbe18e3f809a271efbb27b8da424a

@zeitlinger zeitlinger closed this Oct 4, 2022
@zeitlinger zeitlinger deleted the autocharge branch October 4, 2022 09:39
@zeitlinger zeitlinger restored the autocharge branch October 4, 2022 09:42
@zeitlinger zeitlinger reopened this Oct 4, 2022
@zeitlinger zeitlinger removed their request for review June 15, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Look into autocharge
2 participants
@coyotte508 @zeitlinger