Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rule for too many steps in test case #9

Merged
merged 8 commits into from
Jan 20, 2015

Conversation

guykisel
Copy link
Contributor

@guykisel guykisel commented Dec 2, 2014

Based on https://code.google.com/p/robotframework/wiki/HowToWriteGoodTestCases#Workflow_tests

"Max 10 steps, preferably less"

Example output:

W: 173, 0: Too many steps (13) in test case (TooManyTestSteps)

gkisel added 6 commits December 2, 2014 13:35

Verified

This commit was signed with the committer’s verified signature. The key has expired.
birme Jonas Birmé

Verified

This commit was signed with the committer’s verified signature. The key has expired.
birme Jonas Birmé

Verified

This commit was signed with the committer’s verified signature. The key has expired.
birme Jonas Birmé

Verified

This commit was signed with the committer’s verified signature. The key has expired.
birme Jonas Birmé

Verified

This commit was signed with the committer’s verified signature. The key has expired.
birme Jonas Birmé

Verified

This commit was signed with the committer’s verified signature. The key has expired.
birme Jonas Birmé
@boakley
Copy link
Owner

boakley commented Jan 14, 2015

I'd like to include this rule, but I want it to be configurable. (see Configurable Rules on the wiki). I'll be glad to make it configurable if you want, or you can do it yourself. All you need to do is add a configure method that takes a string as a parameter and sets the maximum number allowed. You can see the otherRules.py:LineTooLong rule for an example.

Sorry it took so long for me to respond.

@guykisel
Copy link
Contributor Author

No problem. I'll make the necessary changes.

@guykisel
Copy link
Contributor Author

@boakley have you pushed the support for configurable rules to github yet? I can't find it in the project source, other than the reference you linked on the wiki.

@boakley
Copy link
Owner

boakley commented Jan 14, 2015

My bad. I didn't realize I had a bunch of stuff I hadn't pushed. It should
be there now.

441f319a

On Wed, Jan 14, 2015 at 4:19 PM, Guy Kisel [email protected] wrote:

@boakley https://github.com/boakley have you pushed the support for
configurable rules to github yet? I can't find it in the project source,
other than the reference you linked on the wiki.


Reply to this email directly or view it on GitHub
#9 (comment)
.

@guykisel
Copy link
Contributor Author

Cool, thanks!

gkisel added 2 commits January 16, 2015 11:45

Verified

This commit was signed with the committer’s verified signature. The key has expired.
birme Jonas Birmé
Conflicts:
	tests/acceptance/self-test.robot

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@guykisel
Copy link
Contributor Author

@boakley I've implemented configurableness. If it looks to you like I've done it correctly, I'll do the same for my other rule PR.

@boakley
Copy link
Owner

boakley commented Jan 16, 2015

Cool. I'll try to take a look at it this weekend.

On Fri, Jan 16, 2015 at 3:25 PM, Guy Kisel [email protected] wrote:

@boakley https://github.com/boakley I've implemented configurableness.
If it looks to you like I've done it correctly, I'll do the same for my
other rule PR.


Reply to this email directly or view it on GitHub
#9 (comment)
.

boakley added a commit that referenced this pull request Jan 20, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
add configurable rule for too many steps in test case
@boakley boakley merged commit 3b7e204 into boakley:master Jan 20, 2015
@guykisel guykisel deleted the test-step-count-rule branch January 20, 2015 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants