Remove deprecated TxtReader usage #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since RobotFramework v3.2.0 TxtReader (and RobotReader) are deprecated as such I copied from v3.1.2 the used methods
|
Downstream maintainer of the conda-forge feedstock for this... would love to see this merged and released! |
|
@boakley Could we get this PR merged and a new robotframework-lint release pushed out, so that we can get upgrade to robotframework 3.2? Much appreciated 👍 |
|
We are anxiously awaiting the merge of this! |
|
Please merge |
|
would be nice to have fixed |
|
Please merge |
|
|
Hey would be nice to finally be able to upgrade to 3.2.1. Could you merge? |
|
Thank you! |
|
Thx |
|
@boakley can you make a release on pypi including this fix? |
Thx for robotframework-lint==1.1 release... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since RobotFramework v3.2.0 TxtReader (and RobotReader) are deprecated as such I copied from v3.1.2 the used methods
Closes #73