Add a way to create JsString
from single ASCII literal without heap allocation
#3927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
js_string
macro to createJsString
from an ASCII literal currently causes heap allocation except for theStaticJsStrings
, andStaticJsStrings
is hard for compiler to do constant evaluation because of theHashMap
.Godbolt Link.
This adds a way to create
JsString
from ASCII literal without heap allocation and it is easy for compiler to evaluate constantly, you could view the asm result in the link.