Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused PIVPN_SERVER from compose env #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FrancYescO
Copy link

@FrancYescO FrancYescO commented Sep 5, 2023

better awk match for PIVPN_SERVER CN var
better handling of HTTPS vars
default PIVPN_SERVER to server.conf

@karabelnikov
Copy link
Contributor

PIVPN_SERVER=${PIVPN_SERVER} and PIVPN_CONF=${PIVPN_CONF} These are required variables for openvpn-admin-plus to work. Also, the server.conf file may have a different name for others, depending on their scenarios. It is better to leave it as a variable rather than a static value for all kinds of scenarios.

@FrancYescO
Copy link
Author

FrancYescO commented Sep 19, 2023

For conf I've just set a default value (like username and password to have a congruence in default values) and not removed the normal function when setted, for PIVPN_CONF value is already not used was just leaved in documentation, it uses some awk magic to match the value (that I've improved in this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants