This repository has been archived by the owner on Feb 6, 2025. It is now read-only.
fix: cannot find parent block during livesync #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
force-pushed
the
fix_parent_issue
branch
from
fb1e429 to
310c156
Compare
forcodedancing
force-pushed
the
fix_parent_issue
branch
from
310c156 to
89286d1
Compare
forcodedancing
force-pushed
the
fix_parent_issue
branch
from
c916e9e to
8414e94
Compare
unclezoro
reviewed
Aug 20, 2024
unclezoro
approved these changes
Aug 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
snapshotmethod (error is not handled previously).Rationale
During live sync of BSC, the executor will try to find the parent from the database, which may not have been committed yet.
Example
Changes
Notable changes:
Potential Impacts