Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: txpool reheap oom #211

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

bugfix: txpool reheap oom #211

wants to merge 4 commits into from

Conversation

andyzhang2023
Copy link
Contributor

Description

There is an oom issue in transaction pool caused by reheap optimization:

  1. The demoted transactions would not be removed unless the pool is full, which means those staled transactions will stay in the priced list forever until the pool overflows.
  2. memory grows too fast if the pool copy all transactions 5 times per second, so we reduce it to 1 time per second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krish-nr krish-nr Awaiting requested review from krish-nr

@owen-reorg owen-reorg Awaiting requested review from owen-reorg

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyzhang2023 @owen-reorg