Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix build issue due to rewording #968

Merged
merged 7 commits into from
Jul 7, 2023

Conversation

forcodedancing
Copy link
Contributor

Description

Fix build issue when merging to master branch, due to rewording.

Rationale

Fix

Example

NA

Changes

Notable changes:

  • merge master

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 49.18% and no project coverage change.

Comparison is base (ec6f414) 49.06% compared to head (de615b2) 49.06%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #968   +/-   ##
========================================
  Coverage    49.06%   49.06%           
========================================
  Files          127      127           
  Lines        12703    12703           
========================================
  Hits          6233     6233           
  Misses        6046     6046           
  Partials       424      424           
Impacted Files Coverage Δ
app/config/config.go 34.46% <0.00%> (ø)
app/reconciliation.go 0.00% <0.00%> (ø)
cmd/bnbchaind/init/snapshot.go 0.00% <0.00%> (ø)
cmd/bnbchaind/init/testnet.go 2.97% <0.00%> (ø)
app/helpers.go 10.07% <14.28%> (ø)
app/genesis.go 64.00% <33.33%> (ø)
app/app.go 73.52% <80.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@unclezoro unclezoro merged commit 02998fb into bnb-chain:develop Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants