Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix wording issue #967

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
steps:
- uses: actions/setup-go@v3
with:
go-version: 1.17
go-version: 1.19
- uses: actions/checkout@v3
- uses: actions/cache@v3
with:
path: ~/go/bin/golangci-lint
key: golangci-lint-1.45.2
key: golangci-lint-1.53.3
- uses: actions/cache@v3
with:
path: |
Expand All @@ -32,6 +32,6 @@ jobs:
uses: golangci/golangci-lint-action@v3
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.45.2
version: v1.53.3
skip-pkg-cache: true
args: --timeout=99m
6 changes: 3 additions & 3 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- name: Setup go
uses: actions/setup-go@v3
with:
go-version: 1.17
go-version: 1.19
- uses: actions/cache@v3
with:
path: ~/go/bin
Expand All @@ -27,15 +27,15 @@ jobs:
# used to debug workflow
# - name: Setup tmate session
# uses: mxschmitt/action-tmate@v3
- run: make bep159_integration_test integration_test
- run: make bep159_integration_test recon_integration_test integration_test
coverage-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Setup go
uses: actions/setup-go@v3
with:
go-version: 1.17
go-version: 1.19
- uses: actions/cache@v3
with:
path: ~/go/bin
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/multi-nodes-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- name: Setup go
uses: actions/setup-go@v3
with:
go-version: 1.17
go-version: 1.19
- run: make docker.build docker.generate docker.start
# fix docker permission issue
- run: chmod 777 -R ~/work/node/node/build/devnet
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: Build Release
strategy:
matrix:
go-version: [1.17.x]
go-version: [1.19.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: Build Release
strategy:
matrix:
go-version: [1.17.x]
go-version: [1.19.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ app/apptest/data
app_test/data
plugins/param/data
plugins/tokens/data

# e2e temp files
e2e/priv_validator_key.json
6 changes: 3 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,6 @@ run:
# If false (default) - golangci-lint acquires file lock on start.
# allow-parallel-runners: false
# Define the Go version limit.
# Mainly related to generics support in go1.18.
# Default: use Go version from the go.mod file, fallback on the env var `GOVERSION`, fallback on 1.17
# go: '1.16'
# Mainly related to generics support in go1.19.
# Default: use Go version from the go.mod file, fallback on the env var `GOVERSION`, fallback on 1.19
# go: '1.19'
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
# Changelog

## v0.10.15
FEATURES
* [\#956](https://github.com/bnb-chain/node/pull/956) [BEP] feat: implement bep255
* [\#964](https://github.com/bnb-chain/node/pull/964) [fix] fix: clear side vote addresses

## v0.10.14
FEATURES
* [\#953](https://github.com/bnb-chain/node/pull/953) [cli] feat:support setting acc prefix when collecting gentxs
* [\#953](https://github.com/bnb-chain/node/pull/953) [cli] feat: support setting acc prefix when collecting gentxs
* [\#957](https://github.com/bnb-chain/node/pull/957) [deps] deps: bump cosmos-sdk to v0.26.5

## v0.10.13
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM golang:1.17-alpine AS build-env
FROM golang:1.19-alpine AS build-env

# Set up dependencies
ENV PACKAGES make git libc-dev bash gcc linux-headers eudev-dev curl ca-certificates
ENV PACKAGES make cmake git libc-dev bash gcc linux-headers eudev-dev curl ca-certificates build-base libc-dev

# Set working directory for the build
WORKDIR /go/src/github.com/bnb-chain/node
Expand All @@ -18,7 +18,7 @@ RUN apk add --no-cache $PACKAGES && \
FROM alpine:3.16.0

# Install dependencies
RUN apk add --update ca-certificates tini bash
RUN apk add --update ca-certificates tini bash gcc

ARG USER=bnbchain
ARG USER_UID=1000
Expand Down
7 changes: 6 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,14 @@ integration_test: build
bep159_integration_test: build
@echo "-->BEP159 Integration Test"
@bash ./scripts/bep159_integration_test.sh

recon_integration_test: build
@echo "-->Recon Integration Test"
@bash ./scripts/recon_integration_test.sh

########################################
### Pre Commit
pre_commit: build test_unit bep159_integration_test integration_test format lint multi-nodes-test
pre_commit: build test_unit recon_integration_test bep159_integration_test integration_test format lint multi-nodes-test

########################################
### Local validator nodes using docker and docker-compose
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Besides, it has many other rich features:
### Environment setup

#### Requirement
Go version above 1.17 is required.
Go version above 1.19 is required.

Please [install it](https://go.dev/doc/install) or use brew on macOS: `brew install go`.

Expand Down
4 changes: 2 additions & 2 deletions app/account_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
func BenchmarkGetAccount(b *testing.B) {
memDB := db.NewMemDB()
logger := log.NewTMLogger(io.Discard)
testApp := NewBinanceChain(logger, memDB, io.Discard)
testApp := NewBNBBeaconChain(logger, memDB, io.Discard)

pk := ed25519.GenPrivKey().PubKey()
addr := sdk.AccAddress(pk.Address())
Expand Down Expand Up @@ -49,7 +49,7 @@ func BenchmarkGetAccount(b *testing.B) {
func BenchmarkSetAccount(b *testing.B) {
memDB := db.NewMemDB()
logger := log.NewTMLogger(io.Discard)
testApp := NewBinanceChain(logger, memDB, io.Discard)
testApp := NewBNBBeaconChain(logger, memDB, io.Discard)

pk := ed25519.GenPrivKey().PubKey()
addr := sdk.AccAddress(pk.Address())
Expand Down
Loading