Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear up side vote addrs #964

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented Jul 5, 2023

Description

clear up all vote addrs when the height of new hardfork reached

Rationale

a part of solving rogue key attack
refer to bnb-chain/bnc-cosmos-sdk#353

Example

Changes

  1. clear up all existed vote address when the height of hardfork reached
  2. upgrade go version to 1.19 and upgrade go lint to 1.53.3
  3. modify Dockerfile, add more package needed when compile and run

PS: change github.com/tendermint/crypto to new created github.com/bnb-chain/tendermint-crypto
github.com/bnb-chain/tendermint-crypto is based on golang.org/x/[email protected] which others mod needed

@pythonberg1997
Copy link
Contributor

Please check the CI issues

Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI issue

@NathanBSC NathanBSC force-pushed the clear_side_vote_addrs branch 3 times, most recently from 1882977 to 13b64b5 Compare July 6, 2023 09:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (a2be24e) 49.10% compared to head (cda4622) 49.02%.

❗ Current head cda4622 differs from pull request most recent head ee7109a. Consider uploading reports for the commit ee7109a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #964      +/-   ##
===========================================
- Coverage    49.10%   49.02%   -0.08%     
===========================================
  Files          127      127              
  Lines        12698    12703       +5     
===========================================
- Hits          6235     6228       -7     
- Misses        6040     6050      +10     
- Partials       423      425       +2     
Impacted Files Coverage Δ
app/app.go 73.52% <0.00%> (-0.39%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@buddh0 buddh0 merged commit fd1da2a into bnb-chain:develop Jul 6, 2023
@NathanBSC NathanBSC deleted the clear_side_vote_addrs branch July 7, 2023 03:49
forcodedancing pushed a commit to forcodedancing/node that referenced this pull request Jul 7, 2023
forcodedancing pushed a commit to forcodedancing/node that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants