-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clear up side vote addrs #964
Conversation
Please check the CI issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI issue
1882977
to
13b64b5
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #964 +/- ##
===========================================
- Coverage 49.10% 49.02% -0.08%
===========================================
Files 127 127
Lines 12698 12703 +5
===========================================
- Hits 6235 6228 -7
- Misses 6040 6050 +10
- Partials 423 425 +2
☔ View full report in Codecov by Sentry. |
cda4622
to
ee7109a
Compare
ee7109a
to
abc676b
Compare
Description
clear up all vote addrs when the height of new hardfork reached
Rationale
a part of solving rogue key attack
refer to bnb-chain/bnc-cosmos-sdk#353
Example
Changes
PS: change github.com/tendermint/crypto to new created github.com/bnb-chain/tendermint-crypto
github.com/bnb-chain/tendermint-crypto is based on golang.org/x/[email protected] which others mod needed