Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bnb wording change #963

Merged
merged 4 commits into from
Jul 7, 2023
Merged

fix: bnb wording change #963

merged 4 commits into from
Jul 7, 2023

Conversation

randyahx
Copy link
Contributor

Description

Perform wording change for binance related terms

Rationale

none

Example

none

Changes

Notable changes:
none

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@randyahx randyahx requested a review from unclezoro July 1, 2023 07:50
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 52.63% and project coverage change: -0.02 ⚠️

Comparison is base (ca00a6f) 49.48% compared to head (564cefe) 49.46%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
- Coverage   49.48%   49.46%   -0.02%     
==========================================
  Files         126      126              
  Lines       12570    12570              
==========================================
- Hits         6220     6218       -2     
- Misses       5930     5933       +3     
+ Partials      420      419       -1     
Impacted Files Coverage Δ
app/config/config.go 34.63% <0.00%> (ø)
cmd/bnbchaind/init/snapshot.go 0.00% <0.00%> (ø)
cmd/bnbchaind/init/testnet.go 2.97% <0.00%> (ø)
app/helpers.go 10.07% <14.28%> (ø)
app/genesis.go 64.00% <33.33%> (ø)
app/app.go 74.21% <80.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

unclezoro
unclezoro previously approved these changes Jul 7, 2023
@unclezoro unclezoro changed the base branch from master to develop July 7, 2023 01:35
@unclezoro unclezoro changed the base branch from develop to master July 7, 2023 01:36
@unclezoro unclezoro dismissed their stale review July 7, 2023 01:36

The base branch was changed.

@unclezoro unclezoro merged commit b5c1003 into bnb-chain:master Jul 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants