Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert the modifications to resource naming rules #568

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

pythonberg1997
Copy link
Contributor

Description

This pr is to revert the previous modifications made to the resource naming rules

Rationale

Checking based on character length is not reasonable and may lead to increased storage space usage.

Changes

Notable changes:

  • revert the length restriction from character length to byte length
  • update error msgs

Potential Impacts

  • related check in sdk

@unclezoro unclezoro added this pull request to the merge queue Jan 23, 2024
Merged via the queue into bnb-chain:develop with commit 781b351 Jan 23, 2024
5 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2024
fix: revert the modifications to resource naming rules (#568)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants