Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bucket status causing event emitted #522

Merged
merged 1 commit into from
Dec 6, 2023
+2 −2
Merged

fix: bucket status causing event emitted #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix bucket status causing event emitted
@alexgao001
alexgao001 committed Nov 9, 2023
commit 15667634fcb556fa96fea9bf70a7666931c8195c
4 changes: 2 additions & 2 deletions x/storage/keeper/keeper.go
View file
Original file line number Diff line number Diff line change
@@ -469,7 +469,7 @@ func (k Keeper) DiscontinueBucket(ctx sdk.Context, operator sdk.AccAddress, buck
if count+1 > max {
return types.ErrNoMoreDiscontinue.Wrapf("no more buckets can be requested in this window")
}

previousStatus := bucketInfo.BucketStatus
bucketInfo.BucketStatus = types.BUCKET_STATUS_DISCONTINUED

store := ctx.KVStore(k.storeKey)
@@ -481,7 +481,7 @@ func (k Keeper) DiscontinueBucket(ctx sdk.Context, operator sdk.AccAddress, buck
k.appendDiscontinueBucketIds(ctx, deleteAt, []sdkmath.Uint{bucketInfo.Id})
k.SetDiscontinueBucketCount(ctx, operator, count+1)

if bucketInfo.BucketStatus == types.BUCKET_STATUS_MIGRATING {
if previousStatus == types.BUCKET_STATUS_MIGRATING {
if err := ctx.EventManager().EmitTypedEvents(&types.EventCancelMigrationBucket{
Operator: operator.String(),
BucketName: bucketInfo.BucketName,