perf: object status judge logic

bnb-chain · Feb 2, 2024 · 4cddc17 · 4cddc17
1 parent 4d45be7
commit 4cddc17
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/e2e/tests/storage_test.go b/e2e/tests/storage_test.go
@@ -2402,6 +2402,8 @@ func (s *StorageTestSuite) TestDeleteCreateObject_InCreatedStatus() {
 	s.Require().Equal(queryHeadObjectResponse.ObjectInfo.Creator, "")
 	// CancelCreateObject
 	msgDeleteCreateObject := storagetypes.NewMsgDeleteObject(user.GetAddr(), bucketName, objectName)
-	s.Require().NoError(err)
 	s.SendTxBlock(user, msgDeleteCreateObject)
+
+	_, err = s.Client.HeadObject(ctx, &queryHeadObjectRequest)
+	s.Require().EqualError(err, "rpc error: code = Unknown desc = No such object: unknown request")
 }
diff --git a/x/storage/keeper/keeper.go b/x/storage/keeper/keeper.go
@@ -890,11 +890,6 @@ func (k Keeper) DeleteObject(
 		return k.CancelCreateObject(ctx, operator, bucketName, objectName, types.CancelCreateObjectOptions{SourceType: types.SOURCE_TYPE_ORIGIN})
 	}
 
-	if objectInfo.ObjectStatus != types.OBJECT_STATUS_SEALED &&
-		objectInfo.ObjectStatus != types.OBJECT_STATUS_DISCONTINUED {
-		return types.ErrObjectNotSealed
-	}
-
 	// check permission
 	effect := k.VerifyObjectPermission(ctx, bucketInfo, objectInfo, operator, permtypes.ACTION_DELETE_OBJECT)
 	if effect != permtypes.EFFECT_ALLOW {