Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deposit and delete operation to GVG in signer and fix a few issue #1258

Merged
merged 4 commits into from
Dec 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions base/gfspapp/app_options.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,12 @@ const (
SignerSuccessRejectMigrateBucket = "signer_reject_migrate_bucket_success"
SignerFailureRejectMigrateBucket = "signer_reject_migrate_bucket_failure"

SignerSuccessDeposit = "signer_deposit_success"
SignerFailureDeposit = "signer_deposit_failure"

SignerSuccessDeleteGlobalVirtualGroup = "signer_delete_global_virtual_group_success"
SignerFailureDeleteGlobalVirtualGroup = "signer_delete_global_virtual_group_failure"

UploaderSuccessPutObject = "uploader_put_object_success"
UploaderFailurePutObject = "uploader_put_object_failure"
)
Expand Down
20 changes: 20 additions & 0 deletions base/gfspapp/sign_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,26 @@ func (g *GfSpBaseApp) GfSpSign(ctx context.Context, req *gfspserver.GfSpSignRequ
metrics.ReqCounter.WithLabelValues(SignerSuccessRejectMigrateBucket).Inc()
metrics.ReqTime.WithLabelValues(SignerSuccessRejectMigrateBucket).Observe(time.Since(startTime).Seconds())
}
case *gfspserver.GfSpSignRequest_Deposit:
txHash, err = g.signer.Deposit(ctx, t.Deposit)
if err != nil {
log.CtxErrorw(ctx, "failed to deposit", "error", err)
metrics.ReqCounter.WithLabelValues(SignerFailureDeposit).Inc()
metrics.ReqTime.WithLabelValues(SignerFailureDeposit).Observe(time.Since(startTime).Seconds())
} else {
metrics.ReqCounter.WithLabelValues(SignerSuccessDeposit).Inc()
metrics.ReqTime.WithLabelValues(SignerSuccessDeposit).Observe(time.Since(startTime).Seconds())
}
case *gfspserver.GfSpSignRequest_DeleteGlobalVirtualGroup:
txHash, err = g.signer.DeleteGlobalVirtualGroup(ctx, t.DeleteGlobalVirtualGroup)
if err != nil {
log.CtxErrorw(ctx, "failed to delete global virtual group", "error", err)
metrics.ReqCounter.WithLabelValues(SignerFailureDeleteGlobalVirtualGroup).Inc()
metrics.ReqTime.WithLabelValues(SignerFailureDeleteGlobalVirtualGroup).Observe(time.Since(startTime).Seconds())
} else {
metrics.ReqCounter.WithLabelValues(SignerSuccessDeleteGlobalVirtualGroup).Inc()
metrics.ReqTime.WithLabelValues(SignerSuccessDeleteGlobalVirtualGroup).Observe(time.Since(startTime).Seconds())
}
default:
log.CtxError(ctx, "unknown gfsp sign request type")
return &gfspserver.GfSpSignResponse{
Expand Down
2 changes: 2 additions & 0 deletions base/gfspclient/interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@ type SignerAPI interface {
SignMigrateGVG(ctx context.Context, task *gfsptask.GfSpMigrateGVGTask) ([]byte, error)
SignBucketMigrationInfo(ctx context.Context, task *gfsptask.GfSpBucketMigrationInfo) ([]byte, error)
RejectMigrateBucket(ctx context.Context, rejectMigrateBucket *storagetypes.MsgRejectMigrateBucket) (string, error)
Deposit(ctx context.Context, deposit *virtualgrouptypes.MsgDeposit) (string, error)
DeleteGlobalVirtualGroup(ctx context.Context, deleteGVG *virtualgrouptypes.MsgDeleteGlobalVirtualGroup) (string, error)
}

// UploaderAPI for mock use
Expand Down
60 changes: 60 additions & 0 deletions base/gfspclient/interface_mock.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 44 additions & 0 deletions base/gfspclient/signer.go
Original file line number Diff line number Diff line change
Expand Up @@ -544,3 +544,47 @@ func (s *GfSpClient) RejectMigrateBucket(ctx context.Context, rejectMigrateBucke
}
return resp.GetTxHash(), nil
}

func (s *GfSpClient) Deposit(ctx context.Context, deposit *virtualgrouptypes.MsgDeposit) (string, error) {
conn, err := s.SignerConn(ctx)
if err != nil {
log.Errorw("failed to connect to signer", "error", err)
return "", ErrRPCUnknownWithDetail("client failed to connect to signer, error: ", err)
}
req := &gfspserver.GfSpSignRequest{
Request: &gfspserver.GfSpSignRequest_Deposit{
Deposit: deposit,
},
}
resp, err := gfspserver.NewGfSpSignServiceClient(conn).GfSpSign(ctx, req)
if err != nil {
log.CtxErrorw(ctx, "client failed to sign deposit", "msg", deposit, "error", err)
return "", ErrRPCUnknownWithDetail("client failed to sign deposit, error: ", err)
}
if resp.GetErr() != nil {
return "", resp.GetErr()
}
return resp.GetTxHash(), nil
}

func (s *GfSpClient) DeleteGlobalVirtualGroup(ctx context.Context, deleteGVG *virtualgrouptypes.MsgDeleteGlobalVirtualGroup) (string, error) {
conn, err := s.SignerConn(ctx)
if err != nil {
log.Errorw("failed to connect to signer", "error", err)
return "", ErrRPCUnknownWithDetail("client failed to connect to signer, error: ", err)
}
req := &gfspserver.GfSpSignRequest{
Request: &gfspserver.GfSpSignRequest_DeleteGlobalVirtualGroup{
DeleteGlobalVirtualGroup: deleteGVG,
},
}
resp, err := gfspserver.NewGfSpSignServiceClient(conn).GfSpSign(ctx, req)
if err != nil {
log.CtxErrorw(ctx, "client failed to sign delete GVG", "msg", deleteGVG, "error", err)
return "", ErrRPCUnknownWithDetail("client failed to sign delete GVG, error: ", err)
}
if resp.GetErr() != nil {
return "", resp.GetErr()
}
return resp.GetTxHash(), nil
}
Loading
Loading