fix: httpcode error #1257
Merged
fix: httpcode error #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constwz
requested review from
ruojunm,
will-2012,
unclezoro and
keefel
as code owners
constwz
force-pushed
the
fix-httpcode
branch
from
afc872d to
90c97c2
Compare
ruojunm
approved these changes
Nov 30, 2023
constwz
force-pushed
the
fix-httpcode
branch
2 times, most recently
from
d499a6e to
d9dc0f0
Compare
constwz
force-pushed
the
fix-httpcode
branch
2 times, most recently
from
19362cc to
954c4da
Compare
will-2012
reviewed
Nov 30, 2023
| errInfo := err.Error()[i+6:] | ||
| var gfspErr GfSpError | ||
| unmarshalErr := json.Unmarshal([]byte(errInfo), &gfspErr) | ||
| if unmarshalErr == nil && gfspErr.HttpStatusCode != 0 { |
There was a problem hiding this comment.
What does the 0 here mean? 200 means http is successful.
There was a problem hiding this comment.
0 indicates that err information is successfully resolved
There was a problem hiding this comment.
Why not use gfspErr.InnerCode != 0? I think gfspErr.HttpStatusCode should be 200 by default.
will-2012
reviewed
Nov 30, 2023
|
Refine the PR Title, |
done |
sysvm
reviewed
Dec 1, 2023
alexgao001
approved these changes
Dec 4, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing the issue of inaccurate error codes in the gateway interface.
Rationale
The error message is lost during the RPC call process, and we need to reparse it.
Example
“the specified bucket does not exist”
The error should return a 404, but it is actually returning a 500.
Changes
Notable changes:
Modified the string method of gfspError to make it easier to parse.
Added parsing logic to the gateway.
Potential Impacts
print log
http code