fix:httpcode #1252
Closed
fix:httpcode #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constwz
requested review from
ruojunm,
will-2012,
unclezoro and
keefel
as code owners
ruojunm
reviewed
Nov 27, 2023
| @@ -43,6 +46,23 @@ func init() { | |||
| }) | |||
| } | |||
|
|
|||
| func GetGfSpErr(err error) *GfSpError { | |||
There was a problem hiding this comment.
what if the passed-in err is already a GfSpError?
There was a problem hiding this comment.
Added type assertions
constwz
force-pushed
the
fix-httpcode
branch
from
286ac90 to
0a75c02
Compare
sysvm
reviewed
Nov 27, 2023
| if len(err.Error())-1 < i+6 { | ||
| return nil | ||
| } | ||
| errInfo := err.Error()[i+6:] |
There was a problem hiding this comment.
The result after the rpc call is "rpc error: code = Unknown desc = xxx" We only focus on xxx
constwz
force-pushed
the
fix-httpcode
branch
from
0a75c02 to
f6aff7f
Compare
constwz
force-pushed
the
fix-httpcode
branch
from
f6aff7f to
affc64a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts