Skip to content

Commit

Permalink
fix: fix the DB checksum ovveriden
Browse files Browse the repository at this point in the history
  • Loading branch information
alexgao001 committed Apr 29, 2024
1 parent bc748a9 commit 41bda27
Showing 1 changed file with 5 additions and 9 deletions.
14 changes: 5 additions & 9 deletions store/sqldb/object_integrity.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (

"github.com/go-sql-driver/mysql"
"gorm.io/gorm"
"gorm.io/gorm/clause"

corespdb "github.com/bnb-chain/greenfield-storage-provider/core/spdb"
"github.com/bnb-chain/greenfield-storage-provider/pkg/metrics"
Expand Down Expand Up @@ -408,15 +409,10 @@ func (s *SpDBImpl) SetReplicatePieceChecksum(objectID uint64, segmentIdx uint32,
PieceChecksum: hex.EncodeToString(checksum),
Version: version,
}
result = s.db.Create(insertPieceHash)
if result.Error != nil && MysqlErrCode(result.Error) == ErrDuplicateEntryCode {
// If all columns are identical to previous, the db.Save will also encounter ErrDuplicateEntryCode, then it should skip.
err = s.db.Save(insertPieceHash).Error
if MysqlErrCode(err) == ErrDuplicateEntryCode {
return nil
}
return err
}
result = s.db.Create(insertPieceHash).Clauses(clause.OnConflict{
Columns: []clause.Column{{Name: "object_id"}, {Name: "segment_index"}, {Name: "redundancy_index"}},
UpdateAll: true,
}).Create(insertPieceHash)
if result.Error != nil || result.RowsAffected != 1 {
err = fmt.Errorf("failed to insert piece hash record: %s", result.Error)
return err
Expand Down

0 comments on commit 41bda27

Please sign in to comment.