feat: Add visibility params

bnb-chain · Mar 19, 2024 · 8d91b2a · 8d91b2a
1 parent d99981c
commit 8d91b2a
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 4 deletions.
diff --git a/examples/nextjs/src/components/object/create/index.tsx b/examples/nextjs/src/components/object/create/index.tsx
@@ -156,6 +156,7 @@ export const CreateObject = () => {
                 bucketName: createObjectInfo.bucketName,
                 objectName: createObjectInfo.objectName,
                 body: file,
+                visibility: VisibilityType.VISIBILITY_TYPE_PUBLIC_READ,
               },
               {
                 type: 'EDDSA',

diff --git a/packages/js-sdk/src/api/objects.ts b/packages/js-sdk/src/api/objects.ts
@@ -212,7 +212,14 @@ export class Objects implements IObject {
   }
 
   public async delegateUploadObject(params: DelegatedPubObjectRequest, authType: AuthType) {
-    const { bucketName, objectName, body, contentType = body.type, timeout = 5000 } = params;
+    const {
+      bucketName,
+      objectName,
+      body,
+      contentType = body.type,
+      timeout = 5000,
+      visibility,
+    } = params;
     verifyBucketName(bucketName);
     verifyObjectName(objectName);
     assertAuthType(authType);
@@ -226,6 +233,7 @@ export class Objects implements IObject {
       objectName,
       contentType,
       body,
+      visibility,
       delegated: true,
     });
     const signHeaders = await this.spClient.signHeaders(reqMeta, authType);

diff --git a/packages/js-sdk/src/clients/spclient/spApis/putObject.ts b/packages/js-sdk/src/clients/spclient/spApis/putObject.ts
@@ -1,5 +1,5 @@
 import { EMPTY_STRING_SHA256, METHOD_PUT } from '@/constants';
-import { ReqMeta } from '@/types';
+import { ReqMeta, VisibilityType } from '@/types';
 import { generateUrlByBucketName } from '@/utils/asserts/s3';
 import { encodePath, getSortQueryParams } from '../auth';
 
@@ -13,9 +13,18 @@ export const getPutObjectMetaInfo = async (
     body: File;
     delegated?: boolean;
     txnHash?: string;
+    visibility?: VisibilityType;
   },
 ) => {
-  const { bucketName, objectName, txnHash, contentType, body, delegated = false } = params;
+  const {
+    bucketName,
+    objectName,
+    txnHash,
+    contentType,
+    body,
+    delegated = false,
+    visibility = VisibilityType.VISIBILITY_TYPE_PRIVATE,
+  } = params;
   const path = `/${encodePath(objectName)}`;
   let queryMap = {};
 
@@ -24,7 +33,7 @@ export const getPutObjectMetaInfo = async (
       delegate: '',
       is_update: 'false',
       payload_size: String(body.size),
-      visibility: '0',
+      visibility: visibility,
     };
   }
 

diff --git a/packages/js-sdk/src/types/sp/PutObject.ts b/packages/js-sdk/src/types/sp/PutObject.ts
@@ -1,3 +1,5 @@
+import { VisibilityType } from '../common';
+
 export type PutObjectRequest = {
   bucketName: string;
   objectName: string;
@@ -12,6 +14,7 @@ export type DelegatedPubObjectRequest = {
   bucketName: string;
   objectName: string;
   body: File;
+  visibility?: VisibilityType;
   endpoint?: string;
   timeout?: number;
   contentType?: string;