fix: SwapRows (#458)

* fix: SwapRows * feat: Assert params
bnb-chain · Dec 29, 2023 · 4cf4abc · 4cf4abc
1 parent d9e0b2f
commit 4cf4abc
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/large-camels-hear.md b/.changeset/large-camels-hear.md
@@ -0,0 +1,5 @@
+---
+'@bnb-chain/reed-solomon': patch
+---
+
+fix: SwapRows
diff --git a/packages/reed-solomon/src/index.js b/packages/reed-solomon/src/index.js
@@ -178,9 +178,6 @@ export class ReedSolomon {
     };
   }
 
-  /**
-   * @param {Array[{index, segChecksum, encodeDataHash}]} encodeShards
-   */
   getChecksumsByEncodeShards(encodeShards) {
     let hashList = [];
     let segChecksumList = [];

diff --git a/packages/reed-solomon/src/matrix.js b/packages/reed-solomon/src/matrix.js
@@ -125,7 +125,7 @@ function gaussianElimination(m) {
     if (m[r][r] === 0) {
       for (let rowBelow = r + 1; rowBelow < rows; rowBelow++) {
         if (m[rowBelow][r] !== 0) {
-          let err = SwapRows(r, rowBelow);
+          let err = SwapRows(m, r, rowBelow);
           if (err !== null) {
             return err;
           }

diff --git a/packages/reed-solomon/src/web.adapter.js b/packages/reed-solomon/src/web.adapter.js
@@ -12,6 +12,9 @@ export class WebAdapterReedSolomon extends ReedSolomon {
   }
 
   async encodeInWorker(sourceData) {
+    if (!this.workerNum || !this.workers)
+      throw new Error('`initWorkers` must be executed first to ensure the number of workers');
+
     // RES is `encodeShards` Array
     let RES = [];
     const chunkList = splitPrice(sourceData, this.segmentSize);