fix err

bnb-chain · Aug 12, 2024 · 244a47e · 244a47e
1 parent 780b2b6
commit 244a47e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/abci/abci.go b/abci/abci.go
@@ -17,6 +17,9 @@ func LastBlockHeight(rpc string) (int64, error) {
 	}
 	defer utils.CloseBody(resp.Body)
 	body, err := io.ReadAll(resp.Body)
+	if err != nil {
+		return 0, err
+	}
 	result := gjson.GetBytes(body, "result.response.last_block_height")
 	return result.Int(), nil
 }
@@ -30,5 +33,8 @@ func BsDBInfoBlockHeight(spHost string, height int64) (string, error) {
 	}
 	defer utils.CloseBody(resp.Body)
 	body, err := io.ReadAll(resp.Body)
+	if err != nil {
+		return "", err
+	}
 	return string(body), nil
 }
diff --git a/checks/dbshard.go b/checks/dbshard.go
@@ -51,12 +51,12 @@ var (
 func CheckDbShard(checkEnv, checkRpc string, checkSpHosts []string) {
 	checkBlockMetrics := promauto.NewGauge(prometheus.GaugeOpts{Name: fmt.Sprintf("%v_sp_db_shard_check_block_height", checkEnv)})
 	lastChainHeight, err := abci.LastBlockHeight(checkRpc)
-	calcHeight := lastChainHeight / 3600 * 3600
-	checkBlockMetrics.Set(float64(calcHeight))
 	if err != nil {
 		checkBlockMetrics.Set(float64(GetBlockHeightErr))
 		return
 	}
+	calcHeight := lastChainHeight / 3600 * 3600
+	checkBlockMetrics.Set(float64(calcHeight))
 
 	checkSpErrCodeMetrics := make([]prometheus.Gauge, len(checkSpHosts))
 	objCountArr := make([][]gjson.Result, len(checkSpHosts))