Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft release v1.4.15 #2701

Merged
merged 21 commits into from
Sep 19, 2024
Merged

Draft release v1.4.15 #2701

merged 21 commits into from
Sep 19, 2024

Conversation

zzzckck
Copy link
Collaborator

@zzzckck zzzckck commented Sep 12, 2024

Description

v1.4.15 is a maintenance release, which mainly has some enhancement on P2P and TxPool module, it also provides some Restful API for L2 and support customized token on BSC faucet.

ChangeList

BUGFIX

  • #2680 txpool: apply miner's gasceil to txpool
  • #2688 txpool: set default GasCeil from 30M to 0
  • #2696 miner: limit block size to eth protocol msg size
  • #2684 eth: Add sidecars when available to broadcasted current block

FEATURE

  • #2672 faucet: with mainnet balance check, 0.002BNB at least
  • #2678 beaconserver: simulated beacon api server for op-stack
  • #2687 faucet: support customized token
  • #2698 faucet: add example for custimized token
  • #2706 faucet: update DIN token faucet support

IMPROVEMENT

  • #2677 log: add some p2p log
  • #2679 build(deps): bump actions/download-artifact in /.github/workflows
  • #2662 metrics: add some extra feature flags as node stats
  • #2675 fetcher: Sleep after marking block as done when requeuing
  • #2695 CI: nancy ignore CVE-2024-8421
  • #2689 consensus/parlia: wait more time when processing huge blocks

Changes

NA

zzzckck and others added 15 commits September 3, 2024 14:27
apply `Eth.Miner.GasCeil` to TxPool even the node did not enable `--mine` option
Otherwise, there could be accmulated pending transactions in txpool.
Take an example:
- Currently, BSC testnet's block gaslimit is 70M, as 20M gas is reserved for
  SystemTxs, the maximum acceptable GasLimit for transaction is 50M.
- TxPool recevied a transaction with GasLimit 60M, it would be accepted in TxPool but it
  will never be accepted by validators. Such kinds of transactions will be kept in txpool
  and gradually make the txpool overflowed
Otherwise the node will be waiting for 500ms before the block fetcher
keeps processing.
This PR tries to improve #2680
If the node did not set `Eth.Miner` in config.toml, the default GasCeil
will be 30000000, it is not an accurate number for both BSC mainnet and testnet.
Set it to 0 means disable the transaction GasLimit check, i.e. the TxPool will
accept transactions with any GasLimit size.
@zzzckck zzzckck marked this pull request as draft September 14, 2024 01:13
@zzzckck zzzckck changed the title WIP: for v1.4.15 Draft release v1.4.15 Sep 18, 2024
@zzzckck zzzckck marked this pull request as ready for review September 18, 2024 06:34
zzzckck and others added 4 commits September 18, 2024 16:56
others changes:
  - remove bsc-docker, as it is broken
  - remove light client, as it is no longer supported
eth/handler: remove duplicate check for lists in body
@zzzckck zzzckck merged commit 206c3b0 into master Sep 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants