fix: should not change agentToOperator while newAgent is zero address #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonberg1997
approved these changes
Jul 24, 2024
NathanBSC
approved these changes
Jul 24, 2024
cosinlink
changed the title
cosinlink
changed the title
unclezoro
approved these changes
Jul 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
fix: not set agentToOperator while newAgent is zero address (#579)
Aces42020
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it should not change
agentToOperatorwhilenewAgentis zero address inupdateAgentfunctionExample
before this fix:
validator A set agent1
agentToOperator[address(0)] == address(0)
validator A update agent to address(0) => caused agentToOperator[address(0)] == validator A
after fix:
validator A set agent1
agentToOperator[address(0)] == address(0)
validator A update agent to address(0) => agentToOperator[address(0)] == address(0)
Changes
Notable changes:
not change
agentToOperatorwhilenewAgentis zero address inupdateAgentfunction...