static analysis changes (#273)

Co-authored-by: forcodedancing <[email protected]>
bnb-chain · Apr 20, 2022 · 19058de · 19058de
1 parent be6f1ac
commit 19058de
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/baseapp/baseapp.go b/baseapp/baseapp.go
@@ -257,8 +257,6 @@ func (app *BaseApp) initFromStore(mainKey sdk.StoreKey) error {
 		blockDB.Close()
 	}
 
-	//TODO(#118): figure out what does this mean! If we keep this, we will get panic: Router() on sealed BaseApp at github.com/BiJie/BinanceChain/app.(*BinanceChain).GetRouter(0xc0004bc080, 0xc000c14000, 0xc0007b9808)
-	//        /Users/zhaocong/go/src/github.com/BiJie/BinanceChain/app/app.go:297 +0x6b
 	//app.Seal()
 
 	return nil

diff --git a/server/constructors.go b/server/constructors.go
@@ -33,7 +33,7 @@ func openTraceWriter(traceWriterFile string) (w io.Writer, err error) {
 		w, err = os.OpenFile(
 			traceWriterFile,
 			os.O_WRONLY|os.O_APPEND|os.O_CREATE,
-			0666,
+			0600,
 		)
 		return
 	}
-Original file line number
+Diff line change
@@ Expand Up @@
     		w, err = os.OpenFile(
     			traceWriterFile,
     			os.O_WRONLY|os.O_APPEND|os.O_CREATE,
-,
+,
     		)
     		return
     	}
@@ Expand Down @@