Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating requirements #778

Merged
merged 2 commits into from
Dec 28, 2021
Merged

updating requirements #778

merged 2 commits into from
Dec 28, 2021

Conversation

srisainachuri
Copy link
Contributor

  • removed unnecessary dependencies and updating versions using pip freeze
  • should resolve pip install errors

@kmeht
Copy link
Member

kmeht commented Dec 1, 2021

This might be a good time to address #599.

@srisainachuri
Copy link
Contributor Author

This might be a good time to address #599.

good point will look into this

Copy link
Contributor

@mathildepm mathildepm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approving for now as a temporary way to make sure installation is smoother. Although Kunal is right that we should look into implementing #599 for future ease of use.

@srisainachuri srisainachuri merged commit 60559eb into master Dec 28, 2021
@erwang01 erwang01 deleted the update-requirements branch January 17, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants