Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow admin to set advisor edit deadline, prevents reassignment of assignments that were not rejected #757

Merged
merged 4 commits into from
Sep 17, 2021
Merged

Allow admin to set advisor edit deadline, prevents reassignment of assignments that were not rejected #757

merged 4 commits into from
Sep 17, 2021

Conversation

srisainachuri
Copy link
Contributor

@srisainachuri srisainachuri commented Jun 15, 2021 •
edited
Loading

#710
Admin can now set date in Conference model for advisor edit deadline.
#731
#748
Assignments now errors if any non-rejected assignment would be overwritten by the new csv assignment upload

@srisainachuri srisainachuri requested a review from mathildepm June 15, 2021 02:24
@srisainachuri srisainachuri marked this pull request as ready for review June 15, 2021 02:25
mathildepm
mathildepm reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@mathildepm mathildepm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remaining comments
Should be noted that this commit also

  1. prettifies some of the code
  2. Prevents Reassignment of assignments that were not rejected

For 2, it might be worth renaming the PR to include it.

huxley/core/models.py Outdated Show resolved Hide resolved
huxley/core/models.py Outdated Show resolved Hide resolved
huxley/core/models.py Outdated Show resolved Hide resolved
huxley/core/models.py Outdated Show resolved Hide resolved
huxley/www/views.py Outdated Show resolved Hide resolved
huxley/www/views.py Outdated Show resolved Hide resolved
huxley/www/views.py Show resolved Hide resolved
huxley/www/views.py Outdated Show resolved Hide resolved
huxley/www/js/utils/_checkDate.js Outdated Show resolved Hide resolved
@srisainachuri srisainachuri changed the title Edit date Allow admin to set advisor edit deadline, prevents reassignment of assignments that were not rejected Sep 16, 2021
mathildepm
mathildepm approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@mathildepm mathildepm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@srisainachuri srisainachuri merged commit 0267a56 into master Sep 17, 2021
@srisainachuri srisainachuri deleted the editDate branch December 28, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathildepm mathildepm mathildepm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srisainachuri @mathildepm