New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes on RegistrationView #605

Merged

kmeht merged 3 commits into bmun:master from tdowds:registration_fixes

Aug 1, 2017

Contributor

tdowds commented Jul 30, 2017 •

edited

Loading

This is a PR to catch some of the bugs on our refactored RegistrationView

doesn't display error messages from the server
password confirmation error
checkboxes in the special committee preferences section wasn't showing up

#531 might help in testing our components more thoroughly when making changes like this in the future

tdowds added 2 commits

July 29, 2017 21:35


          displays errors messages returned from server.

ce2b0c8


          fixed bug with password confirm error.

0598b77

Contributor

m-j-mcdonald commented Jul 30, 2017

These are all good catches. I'll assign someone to #531 to help with this.


          fixed issue with committee pref checkboxes not showing.

114e1d9

tdowds requested a review from kmeht

July 30, 2017 21:34

kmeht merged commit 08cc210 into bmun:master

tdowds deleted the registration_fixes branch

August 2, 2017 21:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet