AutoTest: Introduce User named tuple. #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tuples used to specify users and expected errors were really confusing. We can use named tuples to make this more clear. We can also add some hackery so that the fields are optional (and set to None by default).
| User.__new__.__defaults__ = (None, None, None) | ||
|
|
||
|
|
||
| EXP_NOT_AUTHENTICATED = 'exp_not_authenticated' |
There was a problem hiding this comment.
As we add more errors, it might be a good idea to wrap this in a dictionary and call it expected_errors just so it's clearer we're referencing errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#475) The tuples used to specify users and expected errors were really confusing. We can use named tuples to make this more clear. We can also add some hackery so that the fields are optional (and set to None by default).