-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on corner milling #15
base: master
Are you sure you want to change the base?
Conversation
The first commit can be a "drop-in", but the second should be user-configurable (which profile, and which "depth"). |
Looks great - thanks for the pull request. |
No problem. I force-pushed the last commit as it was missing a line (the definition of delta). |
Hi @Salamandar. I have looked at your changes and at one place the dogbone is missing. |
OK. I think I know what's the issue. I'll check it out. |
I guess a workaround would be to re-add some materials at those places, but meh. BTW, there would be a HUGE performance bump if you only used 2d primitives (then extruded). |
The two commits are independent.
The first one disables milling on where it's not needed. On the screenshot, you can see the milling on the blue corner, and we don't want that.
The second commit changes the dogbone profile. Instead of going far into the part, we can just move at 45° inside the corner.
Here it's the "less extreme dogbone" : http://fablab.ruc.dk/content/images/2017/03/dogbones.jpg