Improvements #8
Closed
Improvements #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise a key certificate would be needed.
Replaced closing tag with self closing tag.
Now the overriding methods are also annotated with NonNull.
Javadoc references couldn't be resolved, because the name of the class was missing.
Declaration access could be weaker so I added private modifiers.
We need the deprecated method for the application to work properly on all supported versions.
LinearLayout elements had relative layout parameters.
Had to rearrange blocks, because only buildscript block can be before plugins block.
Swapped static and final. Put member to the top of the class.
Refactored by extracting method.
|
Sorry, I wanted to create a pull request inside my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's merge all the changes, all the improvements to the master branch!