Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5] [iOS] [UI] As a user, I can see the Splash Screen #55

Merged
merged 7 commits into from
Oct 19, 2022

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Sep 26, 2022

close #5

What happened

Add SplashView for app launch logics.
Add animation to login screen.

Insight

Proof of Work

Simulator.Screen.Recording.-.iPhone.13.Pro.Max.-.2022-10-19.at.09.35.01.mp4

@github-actions
Copy link

github-actions bot commented Sep 26, 2022

1 Warning
⚠️ Big PR

🧛 shared Code Coverage: 96.72%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

AppCoordinator.swift
IOSApp.swift
LaunchScreen.storyboard
LoginView.swift
Podfile
Podfile.lock
RouteCoordinator.swift
Screen.swift
SplashView.swift
ViewId+Splash.swift
ViewId.swift
project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@blyscuit blyscuit self-assigned this Sep 26, 2022
@blyscuit blyscuit added this to the 0.0.2 milestone Sep 26, 2022
@github-actions
Copy link

github-actions bot commented Sep 27, 2022

Current coverage for Survey is 58.70%

Files changed - -
RouteCoordinator.swift 40.00% 🚫
ViewId.swift 90.00%
LoginView.swift 90.75%
SplashView.swift 100.00%
AppCoordinator.swift 100.00%
IOSApp.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit changed the title [#5] Add router and splash screen [#5] [iOS] [UI] As a user, I can see the Splash Screen Sep 27, 2022
Base automatically changed from feature/#6-login-ui to develop September 27, 2022 07:53
@blyscuit blyscuit marked this pull request as ready for review September 29, 2022 05:45
Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing complex here, LGTM 🚀

As a side note, I think we should capitalize the first letter for close #5 in the PR's description 🙏

Copy link
Collaborator

@suho suho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@blyscuit blyscuit requested a review from luongvo October 18, 2022 10:56
Copy link
Collaborator

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now 👌

@blyscuit blyscuit merged commit c439204 into develop Oct 19, 2022
@blyscuit blyscuit deleted the feature/#5-splash-screen branch October 19, 2022 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants