Changes from NSLS-II SIX for clearer error messages about timeouts #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakitin
commented
Dec 7, 2019
| if enums: | ||
| # convert enum values to strings if necessary first: | ||
| if not isinstance(a, str): | ||
| a = enums[a] | ||
| if not isinstance(b, str): | ||
| b = enums[b] | ||
| # then compare the strings | ||
| return a == b | ||
| ret = a == b | ||
| if ret and signal_name == 'rixscam_hdf5_capture': |
There was a problem hiding this comment.
I know, this should be parametrized or removed.
|
Is this worthwhile to keep open @mrakitin? |
|
@klauer, I think this can be closed, but I'd like to keep the branch around. The fix is not general enough, so in case of a follow-up update there will be a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very volatile, work-in-progress PR to the v1.3.x branch, to save the state of the code used at the NSLS-II SIX beamline in the recent attempts to mitigate the random timeout errors. See NSLS-II-SIX/profile_collection#24 (and NSLS-II-SIX/profile_collection#20?) for the context.